Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test coverage for sql lab components #3022

Merged
merged 2 commits into from
Jun 22, 2017
Merged

add test coverage for sql lab components #3022

merged 2 commits into from
Jun 22, 2017

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jun 21, 2017 •
edited

fixes #2846.
fixes #2838.

@graceguo-supercat graceguo-supercat self-assigned this Jun 21, 2017
mistercrunch
mistercrunch approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So stoked to see our coverage go up!

@graceguo-supercat graceguo-supercat merged commit a48e246 into apache:master Jun 22, 2017
@graceguo-supercat graceguo-supercat deleted the gg-TestCoverageSqlLab branch June 22, 2017 17:31
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees

@graceguo-supercat graceguo-supercat

Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5
Projects
None yet
Milestone
No milestone
2 participants
@graceguo-supercat @mistercrunch