New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre fill Druid ports #3266

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
3 participants
@Fokko
Contributor

Fokko commented Aug 9, 2017

Hi all,

For Druid set the default port for the broker and coordinator:
image

These are the default ports of Druid:
http://druid.io/docs/latest/configuration/broker.html
http://druid.io/docs/latest/configuration/coordinator.html

This makes it easier to add a Druid source. In all the example configuration files this port is set to the default port, therefore it might be easier to pre fill this.

Cheers, Fokko

Set default ports Druid
For Druid set the default port for the broker and coordinator.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 9, 2017

Coverage Status

Coverage remained the same at 69.301% when pulling e99f5c4 on Fokko:master into 327c052 on apache:master.

coveralls commented Aug 9, 2017

Coverage Status

Coverage remained the same at 69.301% when pulling e99f5c4 on Fokko:master into 327c052 on apache:master.

@mistercrunch mistercrunch merged commit 0cf0860 into apache:master Aug 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 69.301%
Details

graceguo-supercat added a commit to graceguo-supercat/superset that referenced this pull request Aug 10, 2017

Set default ports Druid (apache#3266)
For Druid set the default port for the broker and coordinator.

mistercrunch added a commit that referenced this pull request Aug 11, 2017

Explore view save modal spec (#3110)
* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* improve test coverage for explore view components:
- SaveModal component
- URLShortLinkButton

* remove comment-out code

* [bugfix] wrong 'Cant have overlap between Series and Breakdowns' (#3254)

* [explore] make edit datasource a basic link (#3244)

* Relying on FAB for font-awesome.min.css (#3261)

* Modernize SQLA pessimistic handling (#3256)

Looks like SQLAlchemy has redefined the best practice around
pessimistic connection handling.

* [webpack] break CSS and JS files while webpackin' (#3262)

* [webpack] break CSS and JS files while webpackin'

* cleaning up some templates

* Fix pylint issue

* import logging (#3264)

* [bugfix] preserve order in groupby (#3268)

Recently in
4c3313b
I introduced an issue where the order of groupby fields might change.

This addresses this issue and will preserve ordering.

* Explicitly add Flask as dependancy (#3252)

* Use sane Celery defaults to prevent tasks from being delayed (#3267)

* Improve the chart type of Visualize in sqllab (#3241)

* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar

* add vizTypes filter

* Set default ports Druid (#3266)

For Druid set the default port for the broker and coordinator.

* [explore] Split large reducer logic in ExploreViewContainer (#3088)

* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts

dimaslv added a commit to dimaslv/superset that referenced this pull request Feb 2, 2018

Set default ports Druid (apache#3266)
For Druid set the default port for the broker and coordinator.

dimaslv added a commit to dimaslv/superset that referenced this pull request Feb 2, 2018

Explore view save modal spec (apache#3110)
* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* improve test coverage for explore view components:
- SaveModal component
- URLShortLinkButton

* remove comment-out code

* [bugfix] wrong 'Cant have overlap between Series and Breakdowns' (apache#3254)

* [explore] make edit datasource a basic link (apache#3244)

* Relying on FAB for font-awesome.min.css (apache#3261)

* Modernize SQLA pessimistic handling (apache#3256)

Looks like SQLAlchemy has redefined the best practice around
pessimistic connection handling.

* [webpack] break CSS and JS files while webpackin' (apache#3262)

* [webpack] break CSS and JS files while webpackin'

* cleaning up some templates

* Fix pylint issue

* import logging (apache#3264)

* [bugfix] preserve order in groupby (apache#3268)

Recently in
apache@4c3313b
I introduced an issue where the order of groupby fields might change.

This addresses this issue and will preserve ordering.

* Explicitly add Flask as dependancy (apache#3252)

* Use sane Celery defaults to prevent tasks from being delayed (apache#3267)

* Improve the chart type of Visualize in sqllab (apache#3241)

* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar

* add vizTypes filter

* Set default ports Druid (apache#3266)

For Druid set the default port for the broker and coordinator.

* [explore] Split large reducer logic in ExploreViewContainer (apache#3088)

* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment