-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webpack] break CSS and JS files while webpackin' #3262
Conversation
Coverage increased (+0.002%) to 69.313% when pulling 301424aeda32ebb512d3ed2d00641b0393e30b24 on mistercrunch:css_extract into 2385cd4 on apache:master. |
Coverage increased (+0.01%) to 69.324% when pulling b909320f96b1acfb42ceea4f4bf24e47788432c8 on mistercrunch:css_extract into 2385cd4 on apache:master. |
b909320
to
9ecd54c
Compare
Coverage increased (+0.01%) to 69.324% when pulling 9ecd54c19e1f8697dc3da889d786481f3c04f7db on mistercrunch:css_extract into be01851 on apache:master. |
2 similar comments
Coverage increased (+0.01%) to 69.324% when pulling 9ecd54c19e1f8697dc3da889d786481f3c04f7db on mistercrunch:css_extract into be01851 on apache:master. |
Coverage increased (+0.01%) to 69.324% when pulling 9ecd54c19e1f8697dc3da889d786481f3c04f7db on mistercrunch:css_extract into be01851 on apache:master. |
* cleaning up some templates
9ecd54c
to
6b11ac9
Compare
|
||
@app.context_processor | ||
def get_js_manifest(): | ||
manifest = {} | ||
try: | ||
with open(APP_DIR + '/static/assets/dist/manifest.json', 'r') as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happened at every request :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* [webpack] break CSS and JS files while webpackin' * cleaning up some templates * Fix pylint issue
* split reducer logic for ExploreViewContainer * fix saveModal component and unit tests * revert changes in SaveModal_spec. will make another commit just to improve test coverage for SaveModal component. * improve test coverage for explore view components: - SaveModal component - URLShortLinkButton * remove comment-out code * [bugfix] wrong 'Cant have overlap between Series and Breakdowns' (#3254) * [explore] make edit datasource a basic link (#3244) * Relying on FAB for font-awesome.min.css (#3261) * Modernize SQLA pessimistic handling (#3256) Looks like SQLAlchemy has redefined the best practice around pessimistic connection handling. * [webpack] break CSS and JS files while webpackin' (#3262) * [webpack] break CSS and JS files while webpackin' * cleaning up some templates * Fix pylint issue * import logging (#3264) * [bugfix] preserve order in groupby (#3268) Recently in 4c3313b I introduced an issue where the order of groupby fields might change. This addresses this issue and will preserve ordering. * Explicitly add Flask as dependancy (#3252) * Use sane Celery defaults to prevent tasks from being delayed (#3267) * Improve the chart type of Visualize in sqllab (#3241) * Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar * add vizTypes filter * Set default ports Druid (#3266) For Druid set the default port for the broker and coordinator. * [explore] Split large reducer logic in ExploreViewContainer (#3088) * split reducer logic for ExploreViewContainer * fix saveModal component and unit tests * revert changes in SaveModal_spec. will make another commit just to improve test coverage for SaveModal component. * remove comment-out code * fix merge confilicts
@graceguo-supercat