[explore] Improved time filters controls #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Aug 25, 2017
mistercrunch
commented
|
LGTM |
timifasubaa
reviewed
Aug 26, 2017
| @@ -9,8 +9,9 @@ | |||
| }, | |||
| "scripts": { | |||
| "test": "mocha --require ignore-styles --compilers js:babel-core/register --require spec/helpers/browser.js --recursive spec/**/*_spec.*", | |||
| "cover": "babel-node node_modules/.bin/babel-istanbul cover _mocha -- --require spec/helpers/browser.js --recursive spec/**/*_spec.*", | |||
| "cover": "babel-node node_modules/.bin/babel-istanbul cover _mocha -- --require ignore-styles spec/helpers/browser.js --recursive spec/**/*_spec.*", | |||
There was a problem hiding this comment.
Why is this necessary?
There was a problem hiding this comment.
Started failing for some reason. Seem like it had to do with the way that react-datetime was importing CSS...
3 similar comments
mistercrunch
commented
Aug 29, 2017
| ) | ||
|
|
||
| from_dttm = utils.parse_human_datetime(since) | ||
| now = datetime.now() |
There was a problem hiding this comment.
removing this created issues where some dashboards had expression like 180 days that would get flipped to be in the past
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.