Call props.onChange only when closing filter

[betodealmeida]

The DateFilterControl component calls props.onChange on its onChange, propagating instantly the values selected before "Ok" is clicked. This PR moves the call to props.OnChange to the close function, so that the new values are propagated only when "Ok" is clicked.

Screencast:

Unit test and lint ran fine:

$ cd superset/assets/javascripts
$ npm i
$ npm run test
...
409 passing (3s)
$ npm run lint
<no messages>

This PR fixes #3868.

[mistercrunch]

LGTM

[graceguo-supercat]

@betodealmeida Your code change has a problem: this.onChange is undefined but still in use. Though there is no exception thrown, because this.onChange is used as callback for setState, it's not a good practice to call undefined function.

[mistercrunch]

thanks @graceguo-supercat we're pushing a fix through

[betodealmeida]

I'll fix with a new PR, removing the callbacks.