Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset issue #4512: fixing histogram #4513

Merged
merged 2 commits into from
Mar 2, 2018

Conversation

ArielStv
Copy link
Contributor

@ArielStv ArielStv commented Mar 1, 2018

This is an attempt to address issue #4512.

  • ticks: setting the max number of ticks to 20, using scientific notation
  • colors: using the same color for all bars
  • annotations: getting rid of text on bars - another option could be to add a setting to toggle them
  • adding an x-axis label option
  • adding a normalization option

superset_pr_screenshot

@@ -1086,7 +1086,8 @@ export const visTypes = {
label: t('Chart Options'),
controlSetRows: [
['color_scheme'],
['link_length'],
['link_length', 'x_axis_label'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the y_axis_label here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@ArielStv ArielStv mentioned this pull request Mar 1, 2018
@hughhhh
Copy link
Member

hughhhh commented Mar 2, 2018

🚢 @mistercrunch

@ArielStv
Copy link
Contributor Author

ArielStv commented Mar 2, 2018

@hughhhh @mistercrunch I have another commit in store that I want to push. Should I

  • update this PR with it?
  • wait for this PR to be merged and create a new one?
  • create a new PR right now in parallel to this one?

The new commit is more involved (adding group by option, multiple metrics, legends, etc)

@graceguo-supercat
Copy link

@ArielStv Merged!

@graceguo-supercat graceguo-supercat merged commit 4135854 into apache:master Mar 2, 2018
@ArielStv
Copy link
Contributor Author

ArielStv commented Mar 2, 2018

thanks a lot!

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* fixing histogram axes and colors, adding normalized and x-axis label options

* adding y-axis label option
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* fixing histogram axes and colors, adding normalized and x-axis label options

* adding y-axis label option
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants