[Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Mar 16, 2018
ghost
commented
added 9 commits
March 1, 2018 13:57
… timezone info; use it as UTC
…es annotations are applied based on the updated chart object after adding all data
…es annotations are applied based on the updated chart object after adding all data
…m/tc-dc/superset into evelynturner/annotation_range_fix
Codecov Report
@@ Coverage Diff @@
## master #4630 +/- ##
==========================================
+ Coverage 71.22% 71.23% +<.01%
==========================================
Files 190 190
Lines 14880 14884 +4
Branches 1098 1099 +1
==========================================
+ Hits 10598 10602 +4
Misses 4279 4279
Partials 3 3
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…es annotations are applied based on the updated chart object after adding all data (apache#4630) * Fix how the annotation layer interpretes the timestamp string without timezone info; use it as UTC * [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data * [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data * Fixed indentation
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jun 12, 2018
graceguo-supercat
pushed a commit
that referenced
this pull request
Jun 14, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Jun 14, 2018
…ache#5181) (cherry picked from commit 585dbe6)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…es annotations are applied based on the updated chart object after adding all data (apache#4630) * Fix how the annotation layer interpretes the timestamp string without timezone info; use it as UTC * [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data * [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data * Fixed indentation
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.