This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry pick annotations empty metrics #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ache#5181) (cherry picked from commit 585dbe6)
(cherry picked from commit a109543)
Never did this when I renamed the folder. `npm run cover` currently doesn't generate a proper coverage report, this fixes it (cherry picked from commit 30111bf)
(cherry picked from commit 95bb175)
(cherry picked from commit 280200f)
(cherry picked from commit 6f05b48)
(cherry picked from commit 4776828)
(cherry picked from commit b380a57)
Codecov Report
@@ Coverage Diff @@
## airbnb-master #52 +/- ##
==================================================
- Coverage 77.45% 63.65% -13.81%
==================================================
Files 44 260 +216
Lines 8672 19669 +10997
Branches 0 1967 +1967
==================================================
+ Hits 6717 12520 +5803
- Misses 1955 7140 +5185
- Partials 0 9 +9
Continue to review full report at Codecov.
|
|
Also added commits from the PR to add Adhoc Metrics to timeseries_limit_metric https://github.com/apache/incubator-superset/pull/5118/commits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking a few fixes
Fixing tooltip displaying metrics in heatmap (apache#5055) (cherry picked from commit 280200f)
fix empty metrics (cherry picked from commit 95bb175)
Repoint .istambul.yml to the right location (apache#5187) (cherry picked from commit 30111bf)
Introduce class attr BaseViz.enforce_numerical_metrics (apache#5176) (cherry picked from commit a109543)
fix Formula type annotation, it doesn't show up since apache#4630 (apache#5181) (cherry picked from commit 585dbe6)
@graceguo-supercat @timifasubaa @john-bodley