Added DeckGL Test #4688
Added DeckGL Test #4688
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4688 +/- ##
==========================================
+ Coverage 71.4% 71.48% +0.08%
==========================================
Files 190 190
Lines 14935 14935
Branches 1102 1102
==========================================
+ Hits 10664 10676 +12
+ Misses 4268 4256 -12
Partials 3 3
Continue to review full report at Codecov.
|
|
|
||
| def test_get_metrics(self): | ||
| form_data = {'size': 'large'} | ||
| datasource = {'type': 'table'} |
There was a problem hiding this comment.
I think datasource expects a derivative of connectors.base.models.BaseDatasource, I'm surprised this works.
| class BaseDeckGLVizTestCase(unittest.TestCase): | ||
|
|
||
| def test_get_metrics(self): | ||
| form_data = {'size': 'large'} |
There was a problem hiding this comment.
Typically a form_data dict will be much larger and have as many keys a specified in that particular viz type. We should talk about a way to test viz.py with examples that represent reality, may by sharing code with the examples, along with assertions to complete/test the examples.
Here are a few test I've added for DeckGL. Wanted to get some early feedback before doing another set.
@mistercrunch