Add missing perms to sql_lab role #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚢 |
mistercrunch
force-pushed
the
fix_sqllab_perms
branch
from
72cd190
to
1f1add2
Compare
The SQL Lab related role that is created programmatically is missing permissions that make SQL Lab functional.
mistercrunch
force-pushed
the
fix_sqllab_perms
branch
from
1f1add2
to
297300f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4714 +/- ##
=======================================
Coverage 71.87% 71.87%
=======================================
Files 204 204
Lines 15323 15323
Branches 1177 1177
=======================================
Hits 11014 11014
Misses 4306 4306
Partials 3 3
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
The SQL Lab related role that is created programmatically is missing permissions that make SQL Lab functional.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
The SQL Lab related role that is created programmatically is missing permissions that make SQL Lab functional.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL Lab related role that is created programmatically is missing
permissions that make SQL Lab functional.