Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] cleaning up test configuration #4806

Merged

Conversation

john-bodley
Copy link
Member

This PR deletes the obsolete run_specfic_test.sh script which is now handled via tox. Additionally the need for setting the SUPERSET_CONFIG environment variable in the testing code as this is also handled via tox here.

@codecov-io
Copy link

codecov-io commented Apr 11, 2018

Codecov Report

Merging #4806 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4806   +/-   ##
=======================================
  Coverage   72.29%   72.29%           
=======================================
  Files         208      208           
  Lines       15522    15522           
  Branches     1202     1202           
=======================================
  Hits        11222    11222           
  Misses       4297     4297           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf9ec0...1d543d8. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@john-bodley john-bodley merged commit dadc057 into apache:master Apr 11, 2018
@john-bodley john-bodley deleted the john-bodley-cleanup-test-config branch April 11, 2018 21:09
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants