[sql] Using read_sql_query instead of read_sql #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4853 +/- ##
=======================================
Coverage 76.96% 76.96%
=======================================
Files 44 44
Lines 8534 8534
=======================================
Hits 6568 6568
Misses 1966 1966
Continue to review full report at Codecov.
|
|
LGTM |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Apr 20, 2018
(cherry picked from commit 8934717)
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Apr 23, 2018
[sql] Using read_sql_query instead of read_sql (apache#4853)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pandas read_sql method either reads a SQL query or a database table (we require only the former) into a DataFrame. This results in an additional query (for non-SQLite databases) to determine whether the
sqlobject represents a SQL query or table name. This is unnecessary as thesqlobject is always a SQL statement when called fromget_df.This PR uses the read_sql_query method instead which merely reads the SQL query into a DataFrame thus saving us executing an unnecessary statement.
Note for context about 15% of all our Presto queries originating from PyHive represented the now obsolete query.