Fixing tooltip displaying metrics in heatmap #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
Codecov Report
@@ Coverage Diff @@
## master #5055 +/- ##
=======================================
Coverage 77.52% 77.52%
=======================================
Files 44 44
Lines 8707 8707
=======================================
Hits 6750 6750
Misses 1957 1957Continue to review full report at Codecov.
|
|
+1 |
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
Jun 14, 2018
(cherry picked from commit 280200f)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heatmap was showing
[object, object]instead of metric name for adhoc metrics because it needed the metric label.@GabeLoins @mistercrunch