[markup] Enable allow-forms #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5062 +/- ##
=======================================
Coverage 77.52% 77.52%
=======================================
Files 44 44
Lines 8707 8707
=======================================
Hits 6750 6750
Misses 1957 1957Continue to review full report at Codecov.
|
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
May 23, 2018
(cherry picked from commit d322e48)
john-bodley
added a commit
that referenced
this pull request
May 24, 2018
This reverts commit d322e48.
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a dashboard contained a markup slice with links to other dashboards, and when one tried to either export or explore a slice on the referenced dashboard the following error occurred:
The solution is simply to enable the
allow-formspermission in the markup iframe component.Note given the complexity of the issue, I'm unsure whether one could write a unit test for this scenario, though I was able to validate the fix in my local environment.
to: @williaster @graceguo-supercat @michellethomas @mistercrunch