-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rolling api introduced in pandas 0.18 #5328
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5328 +/- ##
=======================================
Coverage 61.33% 61.33%
=======================================
Files 369 369
Lines 23484 23484
Branches 2713 2713
=======================================
Hits 14405 14405
Misses 9067 9067
Partials 12 12
Continue to review full report at Codecov.
|
Seems like you should also add a |
You're right. I was originally about to, but thought that 0.18 was so ancient that it was unnecessary. But better to be explicit. |
LGTM |
* Implement new rolling api introduced in pandas 0.18 * Bump pandas to 0.23.1 * Add 0.18 requirement in setup.py * Require >=0.18.0, not just 0.18
* Implement new rolling api introduced in pandas 0.18 * Bump pandas to 0.23.1 * Add 0.18 requirement in setup.py * Require >=0.18.0, not just 0.18
The deprecated
rolling_
functions were removed in the current stable pandas version (0.23). Also bump pandas to0.23.1
inrequirements.txt
. Fixes #5324.