Implement rolling api introduced in pandas 0.18 #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5328 +/- ##
=======================================
Coverage 61.33% 61.33%
=======================================
Files 369 369
Lines 23484 23484
Branches 2713 2713
=======================================
Hits 14405 14405
Misses 9067 9067
Partials 12 12
Continue to review full report at Codecov.
|
This was referenced Jul 4, 2018
|
Seems like you should also add a |
|
You're right. I was originally about to, but thought that 0.18 was so ancient that it was unnecessary. But better to be explicit. |
|
LGTM |
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
* Implement new rolling api introduced in pandas 0.18 * Bump pandas to 0.23.1 * Add 0.18 requirement in setup.py * Require >=0.18.0, not just 0.18
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Implement new rolling api introduced in pandas 0.18 * Bump pandas to 0.23.1 * Add 0.18 requirement in setup.py * Require >=0.18.0, not just 0.18
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated
rolling_functions were removed in the current stable pandas version (0.23). Also bump pandas to0.23.1inrequirements.txt. Fixes #5324.