-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated to click #5410
Migrated to click #5410
Conversation
Flask 0.11 is the built-in integration of the click command line interface. Flask-Migrate support for the new Flask CLI based on Click after Release 2.0.0.
Please fix the merge conflicts and build errors |
* Moved shell context definition to cli.py * Switched shell context definition to use decorator. * Moved create_app definition to cli.py * Fixed InvocationError with a wrapped function
Codecov Report
@@ Coverage Diff @@
## master #5410 +/- ##
==========================================
+ Coverage 59.09% 59.11% +0.02%
==========================================
Files 372 372
Lines 23747 23754 +7
Branches 2758 2758
==========================================
+ Hits 14033 14042 +9
+ Misses 9699 9697 -2
Partials 15 15
Continue to review full report at Codecov.
|
@mistercrunch Fixed. |
Can we now remove |
@mistercrunch Oh, yeah good call. Sorry about that. |
LGTM |
* Migrate flask_script to the Flask built-in click. Flask 0.11 is the built-in integration of the click command line interface. Flask-Migrate support for the new Flask CLI based on Click after Release 2.0.0. * Resolved merge conflicts. * Fixed issue introduced from bad merge. * Fixed flake8 errors, added build to excluded flake8 stuff. * * Moved the FlaskGroup declaration to the driver script. * Moved shell context definition to cli.py * Switched shell context definition to use decorator. * Moved create_app definition to cli.py * Fixed InvocationError with a wrapped function * Added extra newlines between functions * Removed flask-script dependency.
* Migrate flask_script to the Flask built-in click. Flask 0.11 is the built-in integration of the click command line interface. Flask-Migrate support for the new Flask CLI based on Click after Release 2.0.0. * Resolved merge conflicts. * Fixed issue introduced from bad merge. * Fixed flake8 errors, added build to excluded flake8 stuff. * * Moved the FlaskGroup declaration to the driver script. * Moved shell context definition to cli.py * Switched shell context definition to use decorator. * Moved create_app definition to cli.py * Fixed InvocationError with a wrapped function * Added extra newlines between functions * Removed flask-script dependency.
Fixed merge conflicts and linting errors from #4078.