Migrated to click #5410
Merged
Migrated to click #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flask 0.11 is the built-in integration of the click command line interface. Flask-Migrate support for the new Flask CLI based on Click after Release 2.0.0.
|
Please fix the merge conflicts and build errors |
* Moved shell context definition to cli.py * Switched shell context definition to use decorator. * Moved create_app definition to cli.py * Fixed InvocationError with a wrapped function
Codecov Report
@@ Coverage Diff @@
## master #5410 +/- ##
==========================================
+ Coverage 59.09% 59.11% +0.02%
==========================================
Files 372 372
Lines 23747 23754 +7
Branches 2758 2758
==========================================
+ Hits 14033 14042 +9
+ Misses 9699 9697 -2
Partials 15 15
Continue to review full report at Codecov.
|
|
@mistercrunch Fixed. |
|
Can we now remove |
|
@mistercrunch Oh, yeah good call. Sorry about that. |
|
LGTM |
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
* Migrate flask_script to the Flask built-in click. Flask 0.11 is the built-in integration of the click command line interface. Flask-Migrate support for the new Flask CLI based on Click after Release 2.0.0. * Resolved merge conflicts. * Fixed issue introduced from bad merge. * Fixed flake8 errors, added build to excluded flake8 stuff. * * Moved the FlaskGroup declaration to the driver script. * Moved shell context definition to cli.py * Switched shell context definition to use decorator. * Moved create_app definition to cli.py * Fixed InvocationError with a wrapped function * Added extra newlines between functions * Removed flask-script dependency.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Migrate flask_script to the Flask built-in click. Flask 0.11 is the built-in integration of the click command line interface. Flask-Migrate support for the new Flask CLI based on Click after Release 2.0.0. * Resolved merge conflicts. * Fixed issue introduced from bad merge. * Fixed flake8 errors, added build to excluded flake8 stuff. * * Moved the FlaskGroup declaration to the driver script. * Moved shell context definition to cli.py * Switched shell context definition to use decorator. * Moved create_app definition to cli.py * Fixed InvocationError with a wrapped function * Added extra newlines between functions * Removed flask-script dependency.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed merge conflicts and linting errors from #4078.