Fix db migration 3dda56f1c4c6 #5415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
commented
Jul 17, 2018
| from sqlalchemy.ext.declarative import declarative_base | ||
| from sqlalchemy import Column, Integer, Text | ||
|
|
||
| from superset import db | ||
| from superset.utils import parse_human_timedelta |
There was a problem hiding this comment.
this import was missing somehow
Codecov Report
@@ Coverage Diff @@
## master #5415 +/- ##
======================================
Coverage 59.1% 59.1%
======================================
Files 372 372
Lines 23746 23746
Branches 2758 2758
======================================
Hits 14035 14035
Misses 9696 9696
Partials 15 15Continue to review full report at Codecov.
|
timifasubaa
approved these changes
Jul 17, 2018
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jul 26, 2018
(cherry picked from commit 73ec526)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@betodealmeida @williaster @timifasubaa