Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[cherry-pick] migrate all dashboards #66

Merged

Conversation

@graceguo-supercat graceguo-supercat changed the title Cherrypick migrate all dashboard [cherry-pick] migrate all dashboard Jul 24, 2018
@graceguo-supercat graceguo-supercat changed the title [cherry-pick] migrate all dashboard [cherry-pick] migrate all dashboards Jul 24, 2018
@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #66 into airbnb-master will increase coverage by 4.18%.
The diff coverage is 60.34%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master      #66      +/-   ##
=================================================
+ Coverage          61.49%   65.68%   +4.18%     
=================================================
  Files                371      346      -25     
  Lines              23566    21801    -1765     
  Branches            2742     2415     -327     
=================================================
- Hits               14493    14320     -173     
+ Misses              9061     7470    -1591     
+ Partials              12       11       -1
Impacted Files Coverage Δ
...rset/assets/src/dashboard/components/Dashboard.jsx 80.85% <ø> (+0.43%) ⬆️
...et/assets/src/explore/components/controls/index.js 100% <ø> (ø) ⬆️
...et/assets/src/dashboard/reducers/dashboardState.js 94.59% <ø> (ø) ⬆️
superset/utils.py 88.5% <ø> (-0.03%) ⬇️
superset/assets/src/logger.js 95.23% <ø> (-0.36%) ⬇️
...ssets/src/dashboard/containers/DashboardHeader.jsx 100% <ø> (ø) ⬆️
...rset/assets/src/dashboard/components/SaveModal.jsx 71.11% <ø> (-1.23%) ⬇️
superset/assets/src/visualizations/nvd3_vis.js 8.57% <0%> (ø) ⬆️
superset/views/core.py 74.83% <0%> (+1.94%) ⬆️
superset/assets/src/explore/controls.jsx 47.28% <0%> (+2.58%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c571b...83aeade. Read the comment docs.

betodealmeida and others added 13 commits July 25, 2018 20:04
* Allow multiple time shifts

* Handle old form data

(cherry picked from commit 1d3e96b)
* Allow different comparisons when using time shift

* Remove test code

* Remove lead/trail NaN and improve code

* Add headers/subheader

* Update yarn

* Migration script

* Fix migration

* Small fixes

* Trigger tests

* Fix lint

* Fix javascript

(cherry picked from commit 7b4e6c7)
* Move flake8-related packages deps to reqs-dev.txt

My VIM which is integrated with flake8 wouldn't match the output from
travis and would often miss things related to the flake8 plugins
installed using Tox.

By moving this to requirements-dev.txt, we can expect developers would
have the proper configuration locally and get matching results with
Travis when running flake8 or in their IDEs if its integrated with
flake8..

* merging migratinos

* sorting packages

* Specify folder for flake8 processing

* pin pycodestyle==2.3.1

* merge db migrations

(cherry picked from commit fee5023)
* fix migration 3dda56f1c

* add isodate to setup.py:

(cherry picked from commit bea0a0a)
* Migrate dashboard positions data from v1 to v2 format

* UPDATING.md

* rebase onto master

(cherry picked from commit fd2d4b0)
fix a bug in handle empty rows

(cherry picked from commit 7ff02c0)
@graceguo-supercat graceguo-supercat merged commit 6f957bb into airbnb:airbnb-master Jul 26, 2018
@graceguo-supercat graceguo-supercat deleted the gg-MigrateAllDashboard branch August 14, 2018 18:04
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* fix: fallback to default margin when margin is partially set

* feat: can disable axis title

* feat: adjust margin according to axis title visibility

* feat: include margin in formData

* feat: add buildQuery

* fix: address kyle comments

* fix: remove string false
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants