-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No exception on no data #5597
No exception on no data #5597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5597 +/- ##
=========================================
+ Coverage 63.6% 63.6% +<.01%
=========================================
Files 359 359
Lines 22786 22789 +3
Branches 2532 2532
=========================================
+ Hits 14492 14494 +2
- Misses 8279 8280 +1
Partials 15 15
Continue to review full report at Codecov.
|
What will transpire in the UI for a No Data? Right now GeoVis actually uses that exception (400 status code) for indicating there isn't data available. https://github.com/apache/incubator-superset/blob/master/superset/exceptions.py#L25 |
@hughhhh, the UI will now show the yellow bar with the text "No Data". The exception is raised later in |
🚢 |
LGTM |
* No exception on no data * Remove unreachable exception (cherry picked from commit 763eeca)
* No exception on no data * Remove unreachable exception (cherry picked from commit 763eeca)
* No exception on no data * Remove unreachable exception (cherry picked from commit 763eeca)
* No exception on no data * Remove unreachable exception
When trying to replicate a bug I found out to the backend is raising exceptions when no data is returned, both in Druid (explicitly) and in SQLAlchemy (iterating over a
cursor.description
that isNone
).I think the SQLAlchemy bug happens only in conjunction with the
druid
backend, and I recently fixed it (druid-io/pydruid#133). But it's better to be on the safe side here.