Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu on 'import dashboards' page #5623

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Aug 14, 2018

Minor bug fix on legacy MVC page
closes #5576

Also minor cosmetic changes:
screen shot 2018-08-14 at 9 11 34 am

@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #5623 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5623      +/-   ##
==========================================
+ Coverage   63.48%   63.48%   +<.01%     
==========================================
  Files         360      360              
  Lines       22886    22889       +3     
  Branches     2547     2547              
==========================================
+ Hits        14529    14531       +2     
- Misses       8342     8343       +1     
  Partials       15       15
Impacted Files Coverage Δ
superset/models/core.py 85.09% <0%> (-0.1%) ⬇️
superset/viz.py 81.16% <0%> (-0.02%) ⬇️
superset/connectors/druid/models.py 82.56% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1d906...d04d714. Read the comment docs.

@mistercrunch
Copy link
Member Author

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida merged commit 54c9ceb into apache:master Aug 22, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The top menus with drop down are unavailable<master>
3 participants