Handling bigquery dialect when previewing data #5655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @mistercrunch |
superset/db_engine_specs.py
Outdated
| @@ -1410,6 +1414,18 @@ def fetch_data(cls, cursor, limit): | |||
| data = [r.values() for r in data] | |||
| return data | |||
|
|
|||
| """ | |||
There was a problem hiding this comment.
nit: docstring goes inside the method
superset/db_engine_specs.py
Outdated
| """ | ||
| @classmethod | ||
| def _get_fields(cls, cols): | ||
| return [sqla.literal_column(c.get('name') + ' as ' + c.get('name').replace('.','__')) for c in cols] |
There was a problem hiding this comment.
line too long, probably triggers the linter, we lie ~<80 and linter fires at 90
There was a problem hiding this comment.
how about literal_column(c.get('name')).label(c.get('name').replace('.','__')))
There was a problem hiding this comment.
Done. Is there a linter tool like yapf we can standardize on for this repo? So that folks can run it before publishing the PR.
Codecov Report
@@ Coverage Diff @@
## master #5655 +/- ##
===========================================
- Coverage 77.64% 63.49% -14.16%
===========================================
Files 46 360 +314
Lines 9208 22893 +13685
Branches 0 2549 +2549
===========================================
+ Hits 7150 14537 +7387
- Misses 2058 8341 +6283
- Partials 0 15 +15
Continue to review full report at Codecov.
|
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 21, 2018
* Handling bigquery dialect when previewing data * review comments * lint (cherry picked from commit 0fbda33)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* Handling bigquery dialect when previewing data * review comments * lint (cherry picked from commit 0fbda33)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* Handling bigquery dialect when previewing data * review comments * lint (cherry picked from commit 0fbda33)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Handling bigquery dialect when previewing data * review comments * lint
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQuery dialect does not like the use of backtick character in the column name when it is nested field/record type.