Search queries when enter is pressed #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6043 +/- ##
==========================================
+ Coverage 77.79% 77.85% +0.05%
==========================================
Files 46 46
Lines 9398 9400 +2
==========================================
+ Hits 7311 7318 +7
+ Misses 2087 2082 -5
Continue to review full report at Codecov.
|
xtinec
requested changes
Oct 5, 2018
xtinec
reviewed
Oct 8, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query search form has an input field for text search:
I added an event handler so that when pressing enter a search is executed, since I saw many users trying to do this while teaching Superset at work.