-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search queries when enter is pressed #6043
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6043 +/- ##
==========================================
+ Coverage 77.79% 77.85% +0.05%
==========================================
Files 46 46
Lines 9398 9400 +2
==========================================
+ Hits 7311 7318 +7
+ Misses 2087 2082 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good.
A unit test to accompany it would be lovely before submitting. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being slow to respond. Love the new tests!
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
* Search queries when enter is pressed * Add unit test * Remove line * Improve test (cherry picked from commit 96952d0)
The query search form has an input field for text search:
I added an event handler so that when pressing enter a search is executed, since I saw many users trying to do this while teaching Superset at work.