Fix top groups with user defined metrics #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
(cherry picked from commit 247a85b)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top groups is not working when freeform metrics (ie, metrics not configured in the semantic layer) are used. This happens because the code currently does a naive test to determine dimensions: everything that is a not a pre-defined metric is considered a dimension.
In the chart that raised this bug,
SUM(response_content_length)was added:Resulting in the backend considering it as a dimension. I added an extra check verifying that the dimension is actually a column in the datasource (since we can only group by columns).