-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send username in sync request #6113
send username in sync request #6113
Conversation
@mistercrunch a one line fix for the bug that we discussed. |
b15ed51
to
7ac9ec1
Compare
superset/views/core.py
Outdated
@@ -2565,7 +2565,8 @@ def sql_json(self): | |||
data = sql_lab.get_sql_results( | |||
query_id, | |||
rendered_query, | |||
return_results=True) | |||
return_results=True, | |||
user_name=g.user.username) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be sure, let's user_name=g.user.username if g.user else None
as some environments may allow anonymous access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it.
LGTM |
@mistercrunch @betodealmeida All tests passed. Can we merge this one? |
* send username in sync request * nit (cherry picked from commit 91792a5)
* send username in sync request * nit
user_name
is sent tosql_lab.get_sql_results
in running async query (https://github.com/apache/incubator-superset/blob/b15ed5135629eddd21409ac0ca749130dac78055/superset/views/core.py#L2543)but did not get sent in running sync query.