send username in sync request #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mistercrunch a one line fix for the bug that we discussed. |
youngyjd
force-pushed
the
send-username-to-sql-execute-sql
branch
from
b15ed51
to
7ac9ec1
Compare
superset/views/core.py
Outdated
| @@ -2565,7 +2565,8 @@ def sql_json(self): | |||
| data = sql_lab.get_sql_results( | |||
| query_id, | |||
| rendered_query, | |||
| return_results=True) | |||
| return_results=True, | |||
| user_name=g.user.username) | |||
There was a problem hiding this comment.
To be sure, let's user_name=g.user.username if g.user else None as some environments may allow anonymous access
|
LGTM |
|
@mistercrunch @betodealmeida All tests passed. Can we merge this one? |
youngyjd
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* send username in sync request * nit (cherry picked from commit 91792a5)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* send username in sync request * nit
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user_nameis sent tosql_lab.get_sql_resultsin running async query (https://github.com/apache/incubator-superset/blob/b15ed5135629eddd21409ac0ca749130dac78055/superset/views/core.py#L2543)but did not get sent in running sync query.