New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] minor fix for Superset logger #6922
[fix] minor fix for Superset logger #6922
Conversation
@@ -171,10 +171,10 @@ class Header extends React.PureComponent { | |||
} | |||
|
|||
toggleEditMode() { | |||
this.props.setEditMode(!this.props.editMode); | |||
this.props.logEvent(LOG_ACTIONS_TOGGLE_EDIT_DASHBOARD, { | |||
editMode: !this.props.editMode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
umm should editMode
be snake-cased edit_mode
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. thank you 👀 !
Codecov Report
@@ Coverage Diff @@
## master #6922 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 421 421
Lines 20449 20449
Branches 2220 2220
=======================================
Hits 13057 13057
Misses 7260 7260
Partials 132 132
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #6922 +/- ##
==========================================
- Coverage 63.87% 63.87% -0.01%
==========================================
Files 422 422
Lines 20514 20513 -1
Branches 2230 2230
==========================================
- Hits 13103 13102 -1
Misses 7279 7279
Partials 132 132
Continue to review full report at Codecov.
|
13a06ff
to
505c3dd
Compare
Add 2 minor fixes for Superset logger:
@kristw @michellethomas