Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time grain after revert #7228

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Fix time grain, after PR reverting some casing changes (snake/camel case).

TEST PLAN

Filter box now works as expected.

ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[x] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@xtinec @khtruong @datability-io @DiggidyDave

@datability-io
Copy link
Contributor

👍

@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #7228 into lyftga will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           lyftga    #7228   +/-   ##
=======================================
  Coverage   64.49%   64.49%           
=======================================
  Files         425      425           
  Lines       20879    20879           
  Branches     2280     2280           
=======================================
  Hits        13466    13466           
  Misses       7287     7287           
  Partials      126      126
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 42.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a875239...abfcef3. Read the comment docs.

@betodealmeida betodealmeida merged commit 43874b3 into apache:lyftga Apr 4, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants