Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requirements] Bump pydruid version #7835

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Conversation

john-bodley
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR bumps the version of pydruid to 0.5.6 which contains a number of bug fixes and the ability to leverage Druid SQL headers.

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @betodealmeida @mistercrunch

@codecov-io
Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #7835 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7835   +/-   ##
=======================================
  Coverage   65.91%   65.91%           
=======================================
  Files         460      460           
  Lines       22041    22041           
  Branches     2418     2418           
=======================================
  Hits        14529    14529           
  Misses       7392     7392           
  Partials      120      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b6cca...cb3f911. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be updated in setup.py?

@john-bodley
Copy link
Member Author

@etr2460 setup.py defined loose bounds for compatibility requirements. The requirements.txt file pins down the actual dependencies.

@etr2460
Copy link
Member

etr2460 commented Jul 9, 2019

I would've expected the PR to look like this: #7832

Updating the min bounds in setup.py, then running the script at the top of requirements.txt. Seems like you wouldn't want to modify an auto-genned file

@etr2460
Copy link
Member

etr2460 commented Jul 9, 2019

spoke offline and i kinda understand how python deps work now. this should be fine 🤷‍♂

@john-bodley john-bodley changed the title Update requirements.txt [requirements] Bump pydruid version Jul 9, 2019
@john-bodley john-bodley merged commit 8d81c30 into master Jul 9, 2019
@john-bodley john-bodley deleted the john-bodley--pydruid-0.5.6 branch July 9, 2019 15:29
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants