Timing and radii #8988
Merged
Timing and radii #8988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameterizing dot for easy resizing.
Transition timing cleanup
Codecov Report
@@ Coverage Diff @@
## master #8988 +/- ##
=======================================
Coverage 59.16% 59.16%
=======================================
Files 367 367
Lines 11679 11679
Branches 2862 2862
=======================================
Hits 6910 6910
Misses 4590 4590
Partials 179 179Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Jan 23, 2020
|
obligatory |
|
after merge: |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR consolidates CSS transition timings and border-radius properties into a minimized set of values, and centralizes those values in the main
variables.lessfile.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Any changes should be either imperceptible, or in a couple cases, barely perceptible, in the case of a couple border-radius properties that were moved from 5px to 4px. If anyone needs those screenshots, I can slog through to find/add them.
There was also one timing that was sped up, from 1s to 0.3s, in the dashboard editor. You can see the new, faster transition here:
REVIEWERS
@mistercrunch @etr2460