-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timing and radii #8988
Timing and radii #8988
Conversation
parameterizing dot for easy resizing.
Transition timing cleanup
Codecov Report
@@ Coverage Diff @@
## master #8988 +/- ##
=======================================
Coverage 59.16% 59.16%
=======================================
Files 367 367
Lines 11679 11679
Branches 2862 2862
=======================================
Hits 6910 6910
Misses 4590 4590
Partials 179 179 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CATEGORY
Choose one
SUMMARY
This PR consolidates CSS transition timings and border-radius properties into a minimized set of values, and centralizes those values in the main
variables.less
file.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Any changes should be either imperceptible, or in a couple cases, barely perceptible, in the case of a couple border-radius properties that were moved from 5px to 4px. If anyone needs those screenshots, I can slog through to find/add them.
There was also one timing that was sped up, from 1s to 0.3s, in the dashboard editor. You can see the new, faster transition here:
REVIEWERS
@mistercrunch @etr2460