[perf_logging] Add is_cached status when chart has error #9009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
when user loads a dashboard, if query returns 0 row, we will show
no data
and response 400. Superset front-end treat it as error. But the result will still be cached.In front-end logging, we don't log is_cached status when chart has error. this may cause our cache rate not accurate. This PR is trying to fix this case (chart has error, and may also has is_cached status).
TEST PLAN
manual test
REVIEWERS
@etr2460