[perf_logging] Add is_cached status when chart has error (#9009)

apache · Jan 24, 2020 · d0bc04f · d0bc04f
1 parent d3d8603
commit d0bc04f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/superset/assets/src/chart/chartAction.js b/superset/assets/src/chart/chartAction.js
@@ -259,11 +259,12 @@ export function exploreJSON(
         return dispatch(chartUpdateSucceeded(json, key));
       })
       .catch(response => {
-        const appendErrorLog = errorDetails => {
+        const appendErrorLog = (errorDetails, isCached) => {
           dispatch(
             logEvent(LOG_ACTIONS_LOAD_CHART, {
               slice_id: key,
               has_err: true,
+              is_cached: isCached,
               error_details: errorDetails,
               datasource: formData.datasource,
               start_offset: logStart,
@@ -283,7 +284,8 @@ export function exploreJSON(
           return dispatch(chartUpdateStopped(key));
         }
         return getClientErrorObject(response).then(parsedResponse => {
-          appendErrorLog(parsedResponse.error);
+          // query is processed, but error out.
+          appendErrorLog(parsedResponse.error, parsedResponse.is_cached);
           return dispatch(chartUpdateFailed(parsedResponse, key));
         });
       });