New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade typescript to 3.8.2 #9189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9189 +/- ##
=========================================
- Coverage 59.13% 58.93% -0.2%
=========================================
Files 372 372
Lines 11938 11987 +49
Branches 2925 2936 +11
=========================================
+ Hits 7059 7065 +6
- Misses 4699 4742 +43
Partials 180 180
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, thanks for the upgrade!
48ae364
to
904ea19
Compare
CATEGORY
Choose one
SUMMARY
Some
@superset-ui-plugin
uses newer version of Typescript and the build may fail when you try to import the Typescript directly vianpm link
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
All CI/CD should pass.
ADDITIONAL INFORMATION
REVIEWERS