Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade typescript to 3.8.2 #9189

Merged
merged 1 commit into from Feb 25, 2020
Merged

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Feb 21, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Some @superset-ui-plugin uses newer version of Typescript and the build may fail when you try to import the Typescript directly via npm link.

  • Upgrade Typescript to 3.8.2 and fix minor linting issues.
  • Change webpack stats to "minimal" so build errors are more readable.
  • Move .gitignore for frontend code to its own subfolder.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

All CI/CD should pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #9189 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #9189     +/-   ##
=========================================
- Coverage   59.13%   58.93%   -0.2%     
=========================================
  Files         372      372             
  Lines       11938    11987     +49     
  Branches     2925     2936     +11     
=========================================
+ Hits         7059     7065      +6     
- Misses       4699     4742     +43     
  Partials      180      180
Impacted Files Coverage Δ
...uperset-frontend/src/views/chartList/ChartList.tsx 63.39% <0%> (-11.1%) ⬇️
...frontend/src/views/dashboardList/DashboardList.tsx 59.34% <0%> (-10.38%) ⬇️
...rset-frontend/src/components/ListView/ListView.tsx 86.02% <0%> (-6.39%) ⬇️
superset-frontend/src/components/ListView/utils.ts 94.44% <0%> (-4.02%) ⬇️
superset-frontend/src/components/Menu/Menu.jsx 87.5% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efdfc5...904ea19. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments, thanks for the upgrade!

superset-frontend/.gitignore Outdated Show resolved Hide resolved
superset-frontend/package-lock.json Show resolved Hide resolved
@ktmud ktmud changed the title Upgrade typescript to 3.7.5 Upgrade typescript to 3.8.2 Feb 24, 2020
@kristw kristw changed the title Upgrade typescript to 3.8.2 build: upgrade typescript to 3.8.2 Feb 24, 2020
@kristw kristw added the #build label Feb 24, 2020
@etr2460 etr2460 merged commit 1992069 into apache:master Feb 25, 2020
@ktmud ktmud deleted the upgrade-typescript branch April 12, 2020 06:50
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants