Upgrade typescript to 3.8.2

apache · Feb 24, 2020 · 904ea19 · 904ea19
1 parent 3efdfc5
commit 904ea19
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 11 deletions.
diff --git a/.gitignore b/.gitignore
@@ -58,9 +58,6 @@ rat-results.txt
 *.js.map
 node_modules
 npm-debug.log*
-superset-frontend/coverage/*
-superset-frontend/cypress/screenshots
-superset-frontend/cypress/videos
 superset/static/assets
 superset/static/version_info.json
 yarn-error.log

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -488,15 +488,15 @@ best practices.
 
 Superset supports a server-wide feature flag system, which eases the incremental development of features. To add a new feature flag, simply modify `superset_config.py` with something like the following:
 
-```
+```python
 FEATURE_FLAGS = {
     'SCOPED_FILTER': True,
 }
 ```
 
 If you want to use the same flag in the client code, also add it to the FeatureFlag TypeScript enum in `superset-frontend/src/featureFlags.ts`. For example,
 
-```
+```typescript
 export enum FeatureFlag {
   SCOPED_FILTER = 'SCOPED_FILTER',
 }

diff --git a/superset-frontend/.eslintignore b/superset-frontend/.eslintignore
@@ -25,5 +25,6 @@ stylesheets/*
 vendor/*
 docs/*
 src/dashboard/deprecated/*
+src/temp/*
 **/node_modules
 *.d.ts
diff --git a/superset-frontend/.gitignore b/superset-frontend/.gitignore
@@ -0,0 +1,4 @@
+coverage/*
+cypress/screenshots
+cypress/videos
+src/temp
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -218,7 +218,7 @@
     "ts-jest": "^24.0.2",
     "ts-loader": "^5.4.5",
     "tslib": "^1.10.0",
-    "typescript": "^3.5.3",
+    "typescript": "^3.8.2",
     "url-loader": "^1.0.1",
     "webpack": "^4.19.0",
     "webpack-assets-manifest": "^3.0.1",

diff --git a/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts b/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
@@ -19,7 +19,7 @@
 import { safeStringify } from '../../../src/utils/safeStringify';
 
 class Noise {
-  public next: Noise;
+  public next?: Noise;
 }
 
 describe('Stringify utility testing', () => {

diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
@@ -281,7 +281,7 @@ const config = {
     hot: true,
     index: '', // This line is needed to enable root proxying
     inline: true,
-    stats: { colors: true },
+    stats: 'minimal',
     overlay: true,
     port: devserverPort,
     // Only serves bundled files from webpack-dev-server