fix: bump legacy-table-chart to 0.11.20 #9286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
force-pushed
the
bugfix-data-table
branch
from
017baea
to
69ab995
Compare
ktmud
changed the title
ktmud
force-pushed
the
bugfix-data-table
branch
from
69ab995
to
7969905
Compare
ktmud
force-pushed
the
bugfix-data-table
branch
from
7969905
to
8c4902e
Compare
|
Why are there so many package lock changes here? |
Did a fresh rm -rf node_modules package-lock.json && ENV="" NODE_ENV="development" npm installMaybe not a good idea? |
ktmud
force-pushed
the
bugfix-data-table
branch
from
8c4902e
to
b3528e0
Compare
|
@ktmud That is kinda dangerous. |
ktmud
commented
Mar 11, 2020
| @@ -7670,28 +7670,28 @@ | |||
| "dependencies": { | |||
| "abbrev": { | |||
| "version": "1.1.1", | |||
| "resolved": "", | |||
| "resolved": false, | |||
There was a problem hiding this comment.
Empty strings become falses again. 🤦♂
etr2460
approved these changes
Mar 11, 2020
| @@ -7670,28 +7670,28 @@ | |||
| "dependencies": { | |||
| "abbrev": { | |||
| "version": "1.1.1", | |||
| "resolved": "", | |||
| "resolved": false, | |||
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Minor fixes for the data table:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
ADDITIONAL INFORMATION
N/A
REVIEWERS
@etr2460 @graceguo-supercat @kristw