Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use snake_case for error_type #9835

Merged
merged 1 commit into from May 18, 2020
Merged

fix: use snake_case for error_type #9835

merged 1 commit into from May 18, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented May 18, 2020

SUMMARY

To match the api standard, errorType should be error_type instead

TEST PLAN

CI, ensure the error message component is overridden when a custom message is registered

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @graceguo-supercat @john-bodley @kristw

@etr2460 etr2460 merged commit b36738c into apache:master May 18, 2020
@etr2460 etr2460 added the SIP-40 label Jun 2, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@auxten
fix: use snake_case for error_type (apache#9835)
5488cf1
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etr2460 @john-bodley @mistercrunch