fix: use snake_case for error_type (apache#9835)

auxten · Nov 20, 2020 · 5488cf1 · 5488cf1
1 parent d0ca49f
commit 5488cf1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/superset-frontend/spec/javascripts/utils/getClientErrorObject_spec.ts b/superset-frontend/spec/javascripts/utils/getClientErrorObject_spec.ts
@@ -48,7 +48,7 @@ describe('getClientErrorObject()', () => {
     const jsonError = {
       errors: [
         {
-          errorType: ErrorTypeEnum.GENERIC_DB_ENGINE_ERROR,
+          error_type: ErrorTypeEnum.GENERIC_DB_ENGINE_ERROR,
           extra: { engine: 'presto', link: 'https://www.google.com' },
           level: 'error',
           message: 'presto error: test error',

diff --git a/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx b/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx
@@ -40,7 +40,7 @@ export default function ErrorMessageWithStackTrace({
   // Check if a custom error message component was registered for this message
   if (error) {
     const ErrorMessageComponent = getErrorMessageComponentRegistry().get(
-      error.errorType,
+      error.error_type,
     );
     if (ErrorMessageComponent) {
       return <ErrorMessageComponent error={error} />;

diff --git a/superset-frontend/src/components/ErrorMessage/types.ts b/superset-frontend/src/components/ErrorMessage/types.ts
@@ -47,7 +47,7 @@ export type ErrorType = ValueOf<typeof ErrorTypeEnum>;
 export type ErrorLevel = 'info' | 'warning' | 'error';
 
 export type SupersetError = {
-  errorType: ErrorType;
+  error_type: ErrorType;
   extra: Record<string, any> | null;
   level: ErrorLevel;
   message: string;