build: add workflow preferring TypeScript files

[etr2460]

SUMMARY

Adds a Github workflow to check if any .js or .jsx files were added in a PR, and adds a comment to the PR asking to change the files to use TypeScript. This check always passes and will never prevent merge.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Comments when a .js file is added:

Skips the comment step when no js files are added:

TEST PLAN

Add a .js file to this PR and see the message appear. See the comment step skip when no js is added. Also test the jq command locally to ensure it works will all file extensions

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

to: @ktmud @john-bodley @kristw @nytai @graceguo-supercat

[codecov-commenter]

Codecov Report

Merging #9901 into master will increase coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9901      +/-   ##
==========================================
+ Coverage   71.22%   71.67%   +0.44%     
==========================================
  Files         585      585              
  Lines       30828    32789    +1961     
  Branches     3237     3237              
==========================================
+ Hits        21957    23501    +1544     
- Misses       8762     9179     +417     
  Partials      109      109              

Flag	Coverage Δ
#cypress	53.76% <ø> (-0.08%)	⬇️
#javascript	59.38% <ø> (ø)
#python	72.13% <ø> (+0.73%)	⬆️

Impacted Files	Coverage Δ
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx	65.90% <0.00%> (-6.82%)	⬇️
superset/jinja_context.py	84.00% <0.00%> (-1.72%)	⬇️
.../src/dashboard/components/gridComponents/Chart.jsx	86.51% <0.00%> (-1.13%)	⬇️
superset/errors.py	100.00% <0.00%> (ø)
superset/typing.py	100.00% <0.00%> (ø)
superset/viz_sip38.py	0.00% <0.00%> (ø)
superset/utils/import_datasource.py	100.00% <0.00%> (ø)
superset/sql_parse.py	99.30% <0.00%> (+<0.01%)	⬆️
superset/db_engine_specs/base.py	87.24% <0.00%> (+0.03%)	⬆️
superset/connectors/base/models.py	90.58% <0.00%> (+0.12%)	⬆️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9edfc8f...4463234. Read the comment docs.

[github-actions]

It looks like your PR contains new .js or .jsx files. As decided in SIP-36, all new files should be written in TypeScript. Please convert new JavaScript files to TypeScript and then re-request review.

[ktmud]

This is a great idea!

[ktmud]

How about a title to make this more visible

        with:
          msg: |
            ## WARNING: TypeScript Preferred

            It looks like your PR contains new `.js` or `.jsx` files. As decided in [SIP-36](https://github.com/apache/incubator-superset/issues/9101), all new files should be written in TypeScript. Please convert new JavaScript files to TypeScript (`.ts` or `tsx`) then re-request review.

---

WARNING: Prefer TypeScript

It looks like your PR contains new .js or .jsx files. As decided in SIP-36, all new files should be written in TypeScript. Please convert new JavaScript files to TypeScript then re-request review.

---

It'd also be nice if the comment could be deleted when new js was removed from PR.

[etr2460]

That's a good idea, I'll add a title.

I couldn't find a github action for deleting comments unfortunately, so I don't think there's an easy way to implement your second comment...

[etr2460]

ping @ktmud for rereview