Skip to content

Commit

Permalink
build: add workflow preferring TypeScript files (apache#9901)
Browse files Browse the repository at this point in the history
* Add workflow preventing non TypeScript Files

* Create comment_preferring_typescript.md

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Delete comment_preferring_typescript.md

* Create comment_preferring_typescript.md

* Delete comment_preferring_typescript.md

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Update prevent_non_typescript_files.yml

* Create test.js

* Delete test.js

* Update prevent_non_typescript_files.yml

* Rename prevent_non_typescript_files.yml to prefer_typescript.yml

* Update prefer_typescript.yml
  • Loading branch information
Erik Ritter authored and auxten committed Nov 20, 2020
1 parent b2647a6 commit 6c97f86
Showing 1 changed file with 31 additions and 0 deletions.
31 changes: 31 additions & 0 deletions .github/workflows/prefer_typescript.yml
@@ -0,0 +1,31 @@
name: Prefer TypeScript

on:
pull_request:
branches:
- master

jobs:
comment:
name: Comment about preferring TypeScript
runs-on: ubuntu-latest
steps:
- name: Get changed files
id: changed
uses: trilom/file-changes-action@v1.2.3
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
- name: Determine if a .js or .jsx file was added
id: check
run: |
echo ::set-output name=was_js_file_added::$(jq 'map(endswith(".js") or endswith(".jsx"))' ${HOME}/files_added.json | jq 'reduce .[] as $is_js (false; . or $is_js)')
- if: steps.check.outputs.was_js_file_added != 'false'
name: Comment about preferring TypeScript
uses: unsplash/comment-on-pr@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
msg: |
## WARNING: Prefer TypeScript
It looks like your PR contains new `.js` or `.jsx` files. As decided in [SIP-36](https://github.com/apache/incubator-superset/issues/9101), all new files should be written in TypeScript. Please convert new JavaScript files to TypeScript and then re-request review.

0 comments on commit 6c97f86

Please sign in to comment.