Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump superset-ui and implement queryFields in formData #9908

Merged
merged 2 commits into from May 26, 2020

Conversation

villebro
Copy link
Member

SUMMARY

This implements the new queryFields functionality introduced in superset-ui/query: apache-superset/superset-ui#485

TEST PLAN

CI + Local testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #9908 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9908   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files         585      585           
  Lines       30864    30864           
  Branches     3237     3237           
=======================================
  Hits        21984    21984           
  Misses       8771     8771           
  Partials      109      109           
Flag Coverage Δ
#cypress 53.83% <100.00%> (ø)
#javascript 59.38% <100.00%> (ø)
#python 71.40% <ø> (ø)
Impacted Files Coverage Δ
superset-frontend/src/explore/controls.jsx 80.95% <ø> (ø)
superset-frontend/src/explore/controlUtils.js 96.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6dbf8...18b5cad. Read the comment docs.

@villebro villebro requested a review from rusackas May 26, 2020 14:09
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 2c97e72 into apache:master May 26, 2020
@rusackas rusackas deleted the villebro/bump-superset-ui branch May 26, 2020 17:19
pkdotson pushed a commit to preset-io/superset that referenced this pull request May 26, 2020
…9908)

* feat: Bump superset-ui packages for queryFields

* feat: Implement queryField in formData
villebro added a commit to preset-io/superset that referenced this pull request May 27, 2020
villebro added a commit that referenced this pull request May 27, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
…9908)

* feat: Bump superset-ui packages for queryFields

* feat: Implement queryField in formData
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants