Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat: bump superset-ui and implement queryFields in formData … #9931

Merged
merged 1 commit into from May 27, 2020

Conversation

villebro
Copy link
Member

…(#9908)"

This reverts commit 2c97e72.

SUMMARY

This PR caused WordCloud to stop working on dashboards (worked fine on Explore view). While a fix shouldn't be difficult to do, I'd like to add a few proper tests to avoid similar breakage in the future.

TEST PLAN

CI + Local testing.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #9931 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9931      +/-   ##
==========================================
+ Coverage   71.22%   71.30%   +0.07%     
==========================================
  Files         585      585              
  Lines       30871    30872       +1     
  Branches     3239     3239              
==========================================
+ Hits        21989    22012      +23     
+ Misses       8773     8751      -22     
  Partials      109      109              
Flag Coverage Δ
#cypress 53.83% <100.00%> (+0.07%) ⬆️
#javascript 59.41% <100.00%> (ø)
#python 71.51% <ø> (+0.10%) ⬆️
Impacted Files Coverage Δ
superset-frontend/src/explore/controls.jsx 80.95% <ø> (ø)
superset-frontend/src/explore/controlUtils.js 96.93% <100.00%> (ø)
superset/views/core.py 76.58% <0.00%> (+0.52%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 87.64% <0.00%> (+1.12%) ⬆️
superset/connectors/sqla/models.py 90.49% <0.00%> (+1.65%) ⬆️
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 72.72% <0.00%> (+6.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b843e...0499e4a. Read the comment docs.

@villebro villebro changed the title Revert "feat: bump superset-ui and implement queryFields in formData … fix: Revert "feat: bump superset-ui and implement queryFields in formData … May 27, 2020
@villebro villebro merged commit 1b72907 into apache:master May 27, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants