feat: [filter_box] disable instant_filtering by defult #9952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9952 +/- ##
=======================================
Coverage 71.33% 71.34%
=======================================
Files 585 585
Lines 30889 30889
Branches 3237 3237
=======================================
+ Hits 22036 22039 +3
+ Misses 8744 8741 -3
Partials 109 109
Continue to review full report at Codecov.
|
etr2460
reviewed
May 29, 2020
| 'users to hit an [Apply] button', | ||
| default: false, | ||
| description: t( | ||
| 'Whether to apply filters as they change, or wait for users to hit an [Apply] button', |
There was a problem hiding this comment.
Maybe we should add a better description while we're in here too. @sylvia-tomiyama any ideas?
There was a problem hiding this comment.
I checked what other descriptions look like (for consistency...). How about Check to apply filters instantly as they change instead of displaying [Apply] button.
graceguo-supercat
force-pushed
the
gg-InstantFiltering
branch
from
6f9e41a
to
c710897
Compare
|
I will use Zuzana's comment. |
mistercrunch
approved these changes
May 31, 2020
|
Should we consider moving the apply button to the right? |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently filter_box's setting instant_filtering is set to true by default. We found airbnb users usually make large filter_box with multiple filter_fields. When user change filter fields one by one, instant filtering will generate many temporary queries but no use.
This PR is to set default value be false. This change will not affect any existed filter_box settings.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI
ADDITIONAL INFORMATION