Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [filter_box] disable instant_filtering by defult #9952

Merged
merged 1 commit into from Jun 1, 2020
Merged

feat: [filter_box] disable instant_filtering by defult #9952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions superset-frontend/cypress-base/cypress/integration/dashboard/filter.js
View file
Open in desktop
Expand Up @@ -85,6 +85,9 @@ export default () =>
.focus({ force: true })
.type('uth Asia{enter}', { force: true });

// by default, need to click Apply button to apply filter
cy.get('.filter_box button').click({ force: true });

// wait again after applied filters
cy.wait(aliases.filter(x => x !== getAlias(filterId))).then(requests => {
requests.forEach(xhr => {
Expand Down
8 changes: 4 additions & 4 deletions superset-frontend/src/explore/controlPanels/FilterBox.jsx
View file
Open in desktop
Expand Up @@ -55,10 +55,10 @@ export default {
type: 'CheckboxControl',
label: t('Instant Filtering'),
renderTrigger: true,
default: true,
description:
'Whether to apply filters as they change, or wait for ' +
'users to hit an [Apply] button',
default: false,
description: t(
'Check to apply filters instantly as they change instead of displaying [Apply] button',
),
},
},
],
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
View file
Open in desktop
Expand Up @@ -89,7 +89,7 @@ const defaultProps = {
showSqlaTimeColumn: false,
showDruidTimeGrain: false,
showDruidTimeOrigin: false,
instantFiltering: true,
instantFiltering: false,
};

class FilterBox extends React.Component {
Expand Down