feat: support delimiters in hive csv upload #9971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenajiang
commented
Jun 3, 2020
serenajiang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9971 +/- ##
==========================================
- Coverage 68.90% 68.89% -0.01%
==========================================
Files 584 584
Lines 31055 31056 +1
Branches 3180 3180
==========================================
- Hits 21397 21396 -1
- Misses 9549 9551 +2
Partials 109 109
Continue to review full report at Codecov.
|
serenajiang
changed the title
serenajiang
force-pushed
the
serena-hive-csv-upload-delimiters
branch
from
4d93b9c
to
26201b4
Compare
serenajiang
commented
Jun 5, 2020
| sql = f"""CREATE TABLE {str(table)} ( {schema_definition} ) | ||
| ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' STORED AS | ||
| TEXTFILE LOCATION '{location}' | ||
| sql = text( |
There was a problem hiding this comment.
Note text is used for language agnostic :params.
serenajiang
commented
Jun 5, 2020
superset/db_engine_specs/hive.py
Outdated
| engine.execute(sql) | ||
| engine.execute( | ||
| sql, | ||
| delim=csv_to_df_kwargs['sep'].encode().decode('unicode_escape'), |
There was a problem hiding this comment.
Required to escape \\t as \t.
|
@bkyryliuk Used params as suggested. Switched back to the original row format (single character delimiter) because unicode made it hard to use complex delimiters. |
|
ping @bkyryliuk |
bkyryliuk
approved these changes
Jun 10, 2020
serenajiang
force-pushed
the
serena-hive-csv-upload-delimiters
branch
from
d6a0571
to
b10fb8a
Compare
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Co-authored-by: serena-jiang <serena.jiang@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Previously, hive csv upload only supported
,as a delimiter. This is confusing for users because the UI allows you to specify a delimiter.Altered to allow other delimiters.
TEST PLAN
Tested csv + tsv uploads.
ADDITIONAL INFORMATION
@etr2460 @bkyryliuk @john-bodley