Skip to content

Commit

Permalink
[csv upload][hive] support other delimiters (#9971)
Browse files Browse the repository at this point in the history
Co-authored-by: serena-jiang <serena.jiang@airbnb.com>
  • Loading branch information
serenajiang and serenajiang committed Jun 11, 2020
1 parent d1588c7 commit 8744dad
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions superset/db_engine_specs/hive.py
Expand Up @@ -24,7 +24,7 @@

import pandas as pd
from flask import g
from sqlalchemy import Column
from sqlalchemy import Column, text
from sqlalchemy.engine.base import Engine
from sqlalchemy.engine.reflection import Inspector
from sqlalchemy.engine.url import make_url, URL
Expand Down Expand Up @@ -182,13 +182,18 @@ def convert_to_hive_type(col_type: str) -> str:
bucket_path,
os.path.join(upload_prefix, table.table, os.path.basename(filename)),
)

# TODO(bkyryliuk): support other delimiters
sql = f"""CREATE TABLE {str(table)} ( {schema_definition} )
ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' STORED AS
TEXTFILE LOCATION '{location}'
sql = text(
f"""CREATE TABLE {str(table)} ( {schema_definition} )
ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim
STORED AS TEXTFILE LOCATION :location
tblproperties ('skip.header.line.count'='1')"""
engine.execute(sql)
)
engine = cls.get_engine(database)
engine.execute(
sql,
delim=csv_to_df_kwargs["sep"].encode().decode("unicode_escape"),
location=location,
)

@classmethod
def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
Expand Down

0 comments on commit 8744dad

Please sign in to comment.