TAMAYA-379: enforce checkstyle validation

[acoburn]

Updates code to follow checkstyle rules.

For the most part, the changes are trivial and don't affect any visible API:

• replaces star imports with explicit imports
• removes unused imports
• replaces tabs with spaces
• adds missing JavaDocs

There were also a few instances where fields or methods didn't follow case rules. Some of these were private fields (e.g. resolver => RESOLVER), but some were protected (e.g. in the jodatime module, formatter => FORMATTER) and in one case it was a public method (i.e. in metamodel, o.a.t.m.internal.resolver.JavaResolver::TIME becomes JavaResolver::time)

[ottlinger]

@acoburn not sure about the checkstyle rules concerning the casing - following the "official" Javadoc guide I'd also uppercase the private final constants .... not sure, but if the rule is there, we could easily comply with it.

https://www.oracle.com/technetwork/java/codeconventions-135099.html

Constants
The names of variables declared class constants and of ANSI constants should be all uppercase with words separated by underscores ("_"). (ANSI constants should be avoided, for ease of debugging.)
static final int MIN_WIDTH = 4;
static final int MAX_WIDTH = 999;
static final int GET_THE_CPU = 1;

[acoburn]

The current checkstyle configuration defines an allowable format for class-level constants. Our format varies from the default checkstyle format somewhat, permitting a wider range of valid names for class constants.

Would you like to see the checkstyle configuration be changed to be more strict? (i.e. UPPER_CASE?) That change would bring our configuration more in line with the default checkstyle format.

[ottlinger]

Am 27.01.19 um 01:20 schrieb Aaron Coburn:

Would you like to see the checkstyle configuration be changed to be more strict? (i.e. UPPER_CASE?) That change would bring our configuration more in line with the default checkstyle format.

+1 for a more standardized config. Cheers, Phil

[acoburn]

I updated the checkstyle configuration to make use of the default rules for constant (and method) names. This change didn't require any additional code modifications, which means that the code is already (as of this PR) following the standard formatting rules.

[ottlinger]

Great work - thanks.