Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: New Usage Panel fragment instead of Dialogue box in navigation bar #60

Closed

Conversation

Hiteshgautam01
Copy link
Contributor

@Hiteshgautam01 Hiteshgautam01 commented Feb 24, 2018

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the checks with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@sagar15795
Copy link
Member

@Hiteshgautam01
Please first fix your build.
Show the usage section using activity in place of the fragment.
Please read the PR template before submitting any PR.

@Hiteshgautam01
Copy link
Contributor Author

Okay @sagar15795 👍

@Hiteshgautam01
Copy link
Contributor Author

Hiteshgautam01 commented Feb 24, 2018

okay @sagar15795 the build is passing now.
I am closing this pr and send a new PR of activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants