Fix: Replace usage dialogue box with New Usage Activity #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usage Activity UI
|
saketkumar
suggested changes
Mar 1, 2018
There was a problem hiding this comment.
@Hiteshgautam01 Great work! 👍Thanks for the PR. I have added a comment.
| @Override | ||
| protected void onCreate(Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); | ||
| setContentView(R.layout.activity_usage2); |
There was a problem hiding this comment.
@Hiteshgautam01 layout name should be activity_usage only. Why usage2?
saketkumar
suggested changes
Mar 1, 2018
| dialog.setTitle(getString(R.string.title_nav_usage)); | ||
| dialog.setContentView(R.layout.usage_layout); | ||
| dialog.show(); | ||
| Intent i = new Intent(DashboardActivity.this, UsageActivity.class); |
| android:layout_height="match_parent" | ||
| android:orientation="vertical"> | ||
|
|
||
| <android.support.v7.widget.Toolbar |
There was a problem hiding this comment.
@Hiteshgautam01 This is not required here. You just need to include appbar.xml layout file here. appbar.xml file already have Toolbar defined.
|
@saketkumar95 |
Hiteshgautam01
force-pushed
the
FixUsage
branch
2 times, most recently
from
c263a83
to
f48b2ab
Compare
saketkumar
suggested changes
Mar 2, 2018
There was a problem hiding this comment.
@Hiteshgautam01 Everything looks good now. Just fix that checkstyle issue. 👍
| dialog.setTitle(getString(R.string.title_nav_usage)); | ||
| dialog.setContentView(R.layout.usage_layout); | ||
| dialog.show(); | ||
| Intent intent = new Intent(DashboardActivity.this, UsageActivity.class); |
There was a problem hiding this comment.
@Hiteshgautam01 Checkstyle rule is failing here.
saketkumar
approved these changes
Mar 2, 2018
|
@saketkumar95 Thanks for reviewing it. |
|
@Hiteshgautam01 Thanks for the UI improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the checks with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.