Added announce. and favWorkflow presenter Tests and Bug Fixes in Announcements #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar15795
suggested changes
Jun 16, 2018
| @@ -62,7 +62,6 @@ public void detachView() { | |||
|
|
|||
| public void loadAllAnnouncement(int pageNumber) { | |||
| checkViewAttached(); | |||
| getMvpView().showProgressbar(true); | |||
There was a problem hiding this comment.
why have you removed this line?
There was a problem hiding this comment.
Hey @sagar15795 , While announcements are loading, due to this we can see two progress bar at the same time. You can see in this video:- https://drive.google.com/file/d/1GaAdVFM7PGhusLZizwuAo2rIBD2Zj4ly/view?usp=sharing
So, I removed one progress bar in loadAllAnnouncement.
|
@Hiteshgautam01 Great work. Just make sure you will test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the checks with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.